ci: P2 optimizations — split PR workflow, deduplicate lint, webpack cache#5006
Open
PascalThuet wants to merge 1 commit into
Open
Conversation
…ck cache
- Split verify_pull_request into 4 jobs: validate_and_unit_test,
build_modern_artifact, build_legacy_bundle, functional test.
The functional job downloads the modern artifact instead of rebuilding.
- Remove EsLintWebpackPlugin from webpack prod configs (lint already runs
in ci:verify via prebuild).
- Add ci:verify script and refactor prebuild to use it.
- Parallelize modern/legacy builds with concurrently.
- Enable webpack filesystem cache (cache: { type: 'filesystem' }).
Refs Dash-Industry-Forum#5004
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P2 improvements from #5004:
verify_pull_requestinto 4 jobs:validate_and_unit_test,build_modern_artifact,build_legacy_bundle, and the functional test jobwebpack.common.prod.cjsci:verifyand reuse it from bothprebuildand the PR workflowmodernandlegacybuilds withconcurrentlyBenchmarks
Observed on GitHub Actions fork PR runs:
23946829247):verify_pull_requestcompleted in2m40s;merge_build_and_unit_testspent2m22sinBuild and run unit tests23948490424):verify_pull_requestcompleted in2m15s;validate_and_unit_testspent43sin validation,build_modern_artifactspent52sbuildingmodern, andbuild_legacy_bundlespent47sbuildinglegacy25sfaster end-to-end on this fork PR run, while removing the redundantmodernrebuild from the functional pathValidation Notes
validate_and_unit_test,build_modern_artifact, andbuild_legacy_bundlepassed on PR ci: P2 optimizations — split PR workflow, deduplicate lint, webpack cache #5006run_functional_test_single_stream_lambdatestwas skipped because this PR is cross-repository (PascalThuet/dash.js->Dash-Industry-Forum/dash.js) and the workflow guards ongithub.event.pull_request.head.repo.fork == falseDash-Industry-Forum/dash.jsto open a same-repo validation PR, but GitHub returned403 Permission denied, so a maintainer-side branch/PR is still needed to exercise the non-skipped LambdaTest pathTest plan
validate_and_unit_testjob passesbuild_modern_artifactjob produces and uploadsdist-modernbuild_legacy_bundlejob completes after validation passesRefs #5004
🤖 Generated with Claude Code