Abort retrieveManifest requests after reset#5027
Open
robertbryer wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an edge case where calling reset() while an app-driven retrieveManifest() is in flight can allow stale manifest results to be used after a subsequent retrieveManifest() call.
Changes:
- Track the
ManifestLoadercreated byretrieveManifest()soreset()can abort it. - Use the shared loader reference inside
retrieveManifest()and reset it after completion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2188
to
+2193
| }; | ||
|
|
||
| eventBus.on(Events.INTERNAL_MANIFEST_LOADED, handler, self); | ||
|
|
||
| uriFragmentModel.initialize(url); | ||
| manifestLoader.load(url); | ||
| retrieveManifestLoader.load(url); |
Comment on lines
2176
to
2188
| @@ -2179,13 +2184,13 @@ function MediaPlayer() { | |||
| callback(null, e.error); | |||
| } | |||
| eventBus.off(Events.INTERNAL_MANIFEST_LOADED, handler, self); | |||
| manifestLoader.reset(); | |||
| retrieveManifestLoader.reset(); | |||
| }; | |||
| } | ||
|
|
||
| if (retrieveManifestLoader) { | ||
| retrieveManifestLoader.reset(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
reset()whilst a request fromretrieveManifest()is running does not abort the request.This can cause a second retrieveManifest call to succeed with the manifest from the first call, like so: