Skip to content

feat: add setSuspended and isSuspended to globalShortcut#50425

Merged
codebytere merged 1 commit into
mainfrom
allow-shortcut-suspension
Apr 7, 2026
Merged

feat: add setSuspended and isSuspended to globalShortcut#50425
codebytere merged 1 commit into
mainfrom
allow-shortcut-suspension

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Mar 23, 2026

Description of Change

Adds the ability to temporarily suspend and resume global shortcut handling via globalShortcut.setSuspended() and query the current state via globalShortcut.isSuspended(). When suspended, registered shortcuts stop listening and new registrations are rejected. When resumed, previously registered shortcuts are automatically restored.

Checklist

Release Notes

Notes: Added globalShortcut.setSuspended() and globalShortcut.isSuspended() methods to temporarily suspend and resume global shortcut handling.

@codebytere codebytere requested a review from a team March 23, 2026 09:19
@codebytere codebytere added semver/minor backwards-compatible functionality target/42-x-y PR should also be added to the "42-x-y" branch. labels Mar 23, 2026
@codebytere codebytere force-pushed the allow-shortcut-suspension branch 2 times, most recently from 46d2f9f to 05f4469 Compare March 23, 2026 13:19
Adds the ability to temporarily suspend and resume global shortcut
handling via `globalShortcut.setSuspended()` and query the current
state via `globalShortcut.isSuspended()`. When suspended, registered
shortcuts stop listening and new registrations are rejected. When
resumed, previously registered shortcuts are automatically restored.
@codebytere codebytere force-pushed the allow-shortcut-suspension branch from 05f4469 to 4b052df Compare March 23, 2026 13:20
Copy link
Copy Markdown
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Copy Markdown
Member

@reitowo reitowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Copy Markdown
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit 2e74ad2 into main Apr 7, 2026
66 checks passed
@codebytere codebytere deleted the allow-shortcut-suspension branch April 7, 2026 13:21
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Apr 7, 2026

Release Notes Persisted

Added globalShortcut.setSuspended() and globalShortcut.isSuspended() methods to temporarily suspend and resume global shortcut handling.

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Apr 7, 2026

I have automatically backported this PR to "42-x-y", please check out #50777

@trop trop Bot added in-flight/42-x-y merged/42-x-y PR was merged to the "42-x-y" branch. and removed target/42-x-y PR should also be added to the "42-x-y" branch. in-flight/42-x-y labels Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review/approved ✅ merged/42-x-y PR was merged to the "42-x-y" branch. semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants