fix(OverlayPanel): outside-click dismiss not working when cssTransition=false#8255
Merged
Merged
Conversation
melloware
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
How To Resolve
(1) Issue (Behavior)
cssTransition: false, opening OverlayPanel and clicking outside does not dismiss it.hide()isn’t invoked and onExit/onExited never run.(2) Root Cause
onEntered, butuseOverlayListener({ when: visibleState })may still “see” the previous when=false value due to render/effect timing.→ The bind becomes a no-op (or is immediately unbound), so outside clicks never reach
hide().(3) Fix (This PR)
visibleState(i.e., when=true).(4) Test
2025-08-31.2.30.36.mp4
2025-08-31.2.28.32.mp4
2025-08-31.2.29.56.mp4
2025-08-31.2.28.57.mp4